PR author is not in the allowed authors list.

Review Summary by Qodo

Fix Row ID Column Fallback Lookup in Cell Shortcode

🐞 Bug fix

Walkthroughs

• Fix row ID column fallback to use numeric index instead of named key
• Prevents undefined index notices and empty values on numeric column requests
• Uses resolved fallback array value from array_values($data) for consistency

flowchart LR
  A["Column Lookup Request"] --> B{"Named Column Found?"}
  B -->|Yes| C["Return Named Column Value"]
  B -->|No| D["Create Numeric Fallback Array"]
  D --> E["Check Numeric Index"]
  E -->|Found| F["Return Numeric Index Value"]
  E -->|Not Found| G["Return Empty"]

File Changes

Code Review by Qodo

Great, no issues found!

ⓘ The new review experience is currently in Beta. Learn more

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

This is a correct bug fix that ensures consistency between the array key check and value retrieval.

Analysis

The fix in app/Hooks/Handlers/PublicDataHandler.php corrects an inconsistency:

1. The code creates a numerically indexed array: $dataArray = array_values($data)
2. Then checks if the column exists: isset($dataArray[$column])
3. But was retrieving from the wrong array: $data[$column] (old code)
4. Now correctly retrieves from: $dataArray[$column] (fixed code)

This bug would cause issues when accessing table cells by numeric column index if the original $data array had non-sequential or non-numeric keys. The check would pass but the retrieval would fail, resulting in empty values or undefined index notices.